efl_ui_suite: fix errors in focus tests
ClosedPublic
Actions

Authored by bu5hm4n on May 25 2019, 7:54 AM.

Details

Reviewers

zmike
cedric
segfaultxavi

Commits

rEFL52b2701bc3bf: efl_ui_suite: fix errors in focus tests
rEFLfd2defe9b209: efl_ui_suite: fix errors in focus tests

Summary

there have been a few cases where things were just wrong. Like missing
regular nodes in a focus manager that received focus, and stuff like
this. This now fixes all those cases.

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.May 25 2019, 7:54 AM

Herald added a project: efl. · View Herald TranscriptMay 25 2019, 7:54 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.May 25 2019, 7:54 AM

bu5hm4n added a child revision: D9022: efl_ui: add a helper for not tollerating errors in a testsuite.

Harbormaster completed remote builds in B11623: Diff 22445.May 25 2019, 7:59 AM

It seems like this is adding a bunch of check unit tests which should probably be a separate patch?

This revision now requires changes to proceed.May 28 2019, 5:50 AM

remove accident files

Harbormaster completed remote builds in B11649: Diff 22474.May 28 2019, 6:56 AM

i forgot a file in the meson files

Harbormaster completed remote builds in B11651: Diff 22477.May 28 2019, 8:02 AM

zmike accepted this revision.May 28 2019, 8:38 AM

This revision is now accepted and ready to land.May 28 2019, 8:38 AM

Closed by commit rEFL52b2701bc3bf: efl_ui_suite: fix errors in focus tests (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyMay 28 2019, 9:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/Makefile_Elementary.am (1 line)
M		src/lib/elementary/Efl_Ui.h (1 line)
M		src/tests/elementary/efl_ui_test_focus.c (258 lines)
M		src/tests/elementary/efl_ui_test_focus_common.h (3 lines)
M		src/tests/elementary/efl_ui_test_focus_common.c (27 lines)
A	M	src/tests/elementary/focus_manager_test.eo (4 lines)
M		src/tests/elementary/meson.build (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22445	38d7d33		May 25 2019, 7:54 AM	★	★
Diff 2	22474	7024b19	remove accident files	May 28 2019, 6:55 AM	★	★
Diff 3	22477	7024b19	i forgot a file in the meson files	May 28 2019, 8:02 AM	★	★
Diff 4	22481	a219743	rEFL52b2701bc3bfb64a3f6ca4ce0b992ac83d7c9e73	May 28 2019, 9:01 AM	★	★