Page MenuHomePhabricator

eolian: allow parts named like methods
ClosedPublic

Authored by segfaultxavi on May 28 2019, 1:12 AM.

Details

Summary

The C# bindings turn parts into class properties, so part names cannot clash
with method names.
However, a "Part" prefix has been recently added, just like it was done for
events, and therefore this eolian restriction can be lifted.
With this patch part name clashes are only checked among parts, just like it
is done for events.

Relates to D8582

Test Plan

Everything still builds, because we have no part-method name clashes in the tree, but now they are possible.

Diff Detail

Repository
rEFL core/efl
Branch
devs/xartigas/eolian-remove-parts-check
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11643
Build 8722: arc lint + arc unit
segfaultxavi created this revision.May 28 2019, 1:12 AM
segfaultxavi requested review of this revision.May 28 2019, 1:12 AM
q66 accepted this revision.May 28 2019, 8:10 AM

Hm, I think it's fine.

This revision is now accepted and ready to land.May 28 2019, 8:10 AM
q66 added a comment.May 28 2019, 8:13 AM

Just running tests before landing this now.

q66 closed this revision.May 28 2019, 8:17 AM