Page MenuHomePhabricator

efl_ui: rename list empty item to list placeholder item.

Authored by SanghyeonLee on May 29 2019, 4:08 AM.



legacy full style item is introduced Efl.Ui.ListEmptyItem Class in new Efl Interface,
but using "Empty" name is too ambiguous to present style usage.
Thanks to @cedric and @segfaultxavi,
I found better name for this class, Efl.Ui.ListPlaceHolderItem,
as item hold the place which need to be replaced and relayouted by user generated content.

Depends on D8582

Diff Detail

rEFL core/efl
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
SanghyeonLee created this revision.May 29 2019, 4:08 AM
SanghyeonLee requested review of this revision.May 29 2019, 4:08 AM
segfaultxavi requested changes to this revision.May 29 2019, 5:02 AM

Please note that "placeholder", as a single word, is the most common spelling in English and therefore you should not separate it anywhere, including file names (place_holder, Place_Holder, PLACE_HOLDER).

This revision now requires changes to proceed.May 29 2019, 5:02 AM

yeah I was consider it as a single noun, "placeholder"... it is my mistake. I'll fix it :)

fix place_holder to placeholder

remove diff of depends patch

remove unnecessary spaces.

@SanghyeonLee is it ready for another review?

I change the place_holder to placeholder so is there no problem in the name,
I think it is ready to land.

eagleeye accepted this revision.May 29 2019, 11:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 29 2019, 11:39 PM
This revision was automatically updated to reflect the committed changes.