Page MenuHomePhabricator

Efl.Ui.Radio: Update docs
ClosedPublic

Authored by segfaultxavi on May 31 2019, 3:56 AM.

Details

Summary

Depends on D9060
Ref T7867

Test Plan

Only docs have been changed. Everything builds without warnings, including DocFX.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
segfaultxavi created this revision.May 31 2019, 3:56 AM
segfaultxavi requested review of this revision.May 31 2019, 3:56 AM

Thank you a lot for this, I have only 3 nitpicks where i would lineout the exact behavior a bit more.

src/lib/elementary/efl_ui_radio.eo
26

And thus cannot be taken

src/lib/elementary/efl_ui_radio_box.eo
6

The group is not really a internal and invisible, its composited'ed to the object here, you can manually register/unregstier here.

src/lib/elementary/efl_ui_radio_group.eo
59

"or -1 if no button is selected ?"

Clarifications.

segfaultxavi marked 3 inline comments as done.May 31 2019, 4:19 AM
bu5hm4n accepted this revision.May 31 2019, 4:23 AM
This revision is now accepted and ready to land.May 31 2019, 4:23 AM
Closed by commit rEFLff97b0ed3dec: Efl.Ui.Radio: Update docs (authored by segfaultxavi, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJun 20 2019, 8:03 AM
This revision was automatically updated to reflect the committed changes.