Page MenuHomePhabricator

vg_common_json: Set container's alpha color
ClosedPublic

Authored by jsuya on Jun 11 2019, 12:13 AM.

Details

Summary

If the layer has an alpha value, we have make it available to container.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Branch
devs/hermet/lottie
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11749
Build 8765: arc lint + arc unit
jsuya created this revision.Jun 11 2019, 12:13 AM
jsuya requested review of this revision.Jun 11 2019, 12:13 AM
Hermet requested changes to this revision.Jun 11 2019, 1:36 AM

Please check comments.

src/static_libs/vg_common/vg_common_json.c
285

That's default, Unnecessary call

305

That's default, Unnecessary call

365

Please do this only if alpha is less than 255..

Plus, I think below is enough to go.

if (clayer->mAlpha < 255)

efl_gfx_color_set(ctree, clayer->mAlpha, clayer->mAlpha, clayer->mAlpha, clayer->mAlpha);
449

same with the above comment.

This revision now requires changes to proceed.Jun 11 2019, 1:36 AM
jsuya updated this revision to Diff 22693.Jun 11 2019, 2:20 AM

Fix code

jsuya updated this revision to Diff 22694.Jun 11 2019, 2:24 AM
jsuya marked 2 inline comments as done.

update code

Hermet accepted this revision.Jun 11 2019, 2:59 AM
This revision is now accepted and ready to land.Jun 11 2019, 2:59 AM
Hermet closed this revision.Jun 11 2019, 3:05 AM