Page MenuHomePhabricator

efl_canvas_vg_container: Initialize alpha color
ClosedPublic

Authored by jsuya on Tue, Jun 11, 9:19 PM.

Details

Summary

The vg object (container, shape, ...) follows color of VG node data.
The color of node data is not initialized. it can set the required color for each object.
vg container should be layer with an alpha value of 255.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Tue, Jun 11, 9:19 PM
jsuya requested review of this revision.Tue, Jun 11, 9:19 PM
jsuya updated this revision to Diff 22698.Wed, Jun 12, 12:01 AM
jsuya retitled this revision from efl_cavas_vg_container: Initialize alpha color to efl_canvas_vg_container: Initialize alpha color.

fix typo

Hermet requested changes to this revision.Wed, Jun 12, 7:03 PM

Please check a comment.

src/lib/evas/canvas/efl_canvas_vg_container.c
230

I think it can be initialized in efl_canvas_vg_node class.

This revision now requires changes to proceed.Wed, Jun 12, 7:03 PM
jsuya added inline comments.Wed, Jun 12, 9:19 PM
src/lib/evas/canvas/efl_canvas_vg_container.c
230

@Hermet
That way, fill color is displayed on the shape that has only line information.
Perhaps we can set color to 0 in vg_common depending on the fill information.
But I think it is better to set only the visibility of the layer in advance.

Hermet accepted this revision.Wed, Jun 12, 9:55 PM

And this doesn't initialize alpha but default color.

This revision is now accepted and ready to land.Wed, Jun 12, 9:55 PM
This revision was automatically updated to reflect the committed changes.