Page MenuHomePhabricator

[edje] Add support for map zoom to use other part center.
ClosedPublic

Authored by subodh6129 on Jun 19 2019, 5:39 AM.

Details

Summary

Current:
In edc, zoom is supposed to happen from object center, there is no way to
change the center of the zoom.

Changes:
Adding support to change the center of zooming just like map rotation by using
other part's center.

@feature

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
subodh6129 created this revision.Jun 19 2019, 5:39 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

subodh6129 requested review of this revision.Jun 19 2019, 5:39 AM
zmike requested changes to this revision.Jun 19 2019, 6:45 AM
zmike added a subscriber: zmike.

This seems okay to me other than the doc typo. It needs a real commit message, however, to explain the purpose of the patch.

src/bin/edje/edje_cc_handlers.c
14329

I think you meant zooming instead of rotating?

This revision now requires changes to proceed.Jun 19 2019, 6:45 AM
subodh6129 retitled this revision from [edje] Add zoom center part to [edje] Add support for map zoom to use other part center..Jun 19 2019, 9:44 PM
subodh6129 edited the summary of this revision. (Show Details)

Are there any tests/examples using this feature?

subodh6129 updated this revision to Diff 23310.Jul 12 2019, 2:20 AM

example updated

zmike requested changes to this revision.Jul 12 2019, 6:01 AM

The example should be added into the build to ensure that it is compiled.

This revision now requires changes to proceed.Jul 12 2019, 6:01 AM
subodh6129 updated this revision to Diff 23315.Jul 12 2019, 6:24 AM
  • example edc added to build list
zmike accepted this revision.Jul 12 2019, 6:53 AM
This revision is now accepted and ready to land.Jul 12 2019, 6:53 AM
This revision was automatically updated to reflect the committed changes.