Page MenuHomePhabricator

ci: move release-ready to default build and enable tests+install on it

Authored by zmike on Jun 19 2019, 6:51 AM.



with meson, the only difference between our 'default' and 'release-ready'
builds is that the release build uses a different build type which sets
some compile/build flags. these should not provide any differing coverage
over a regular build, so we can reduce our job matrix by one here

Diff Detail

rEFL core/efl
Lint OK
No Unit Test Coverage
Build Status
Buildable 11856
zmike created this revision.Jun 19 2019, 6:51 AM
zmike requested review of this revision.Jun 19 2019, 6:51 AM
stefan_schmidt accepted this revision.Jun 26 2019, 7:25 AM

This looks good. A great side effect is that we would be down to 5 jobs for a push, aka the exact number of parallel jobs we can have. No more waiting. :-)

I had to rebase due my coverity change from yesterday. If CI is happy I will push it out.

This revision is now accepted and ready to land.Jun 26 2019, 7:25 AM
zmike added a comment.Jun 26 2019, 7:26 AM

less jobs is always good!

oh wait, it also pulls release-ready into the push builds from daily. Hope this does not impact our build time. Will know more after the CI does finish

The release-ready build job needs to stay as a cron job. It is taking over 36 minutes to finish. This totally blows our nice 11 minute total time for push builds right now. :-)

The extra benefit is that we do indeed have only 5 jobs left for the push builds with this change which means all can run in parallel. :-)

There is also a break in the release build, but I do not assume this comes from this change.


This has to stay

I got it down to 20 minutes, but it looks like something is fucking up ccache hit rate. I think I should be able to resolve this with a bit more time...

Alright this is fixed in upstream meson but it'll probably be a while before the changes are available and I don't really want to be patching meson manually on CI