Page MenuHomePhabricator

eina: remove unused function body
AbandonedPublic

Authored by JongminLee on Jun 25 2019, 3:28 AM.

Details

Summary

A coverage report program may not generate correct report due to the unused function body.
eina_mempool_alignof() function is defined in eina_inline_mempool.x file, instead.

Test Plan

compilation

Diff Detail

Repository
rEFL core/efl
Branch
work
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11947
Build 8809: arc lint + arc unit
JongminLee created this revision.Jun 25 2019, 3:28 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

JongminLee requested review of this revision.Jun 25 2019, 3:28 AM
JongminLee edited the test plan for this revision. (Show Details)Jun 25 2019, 3:34 AM
Hermet requested changes to this revision.Jun 25 2019, 5:35 AM

There are a lot of calls, is it wrong?

lib/eo/eo_ptr_indirection.x:247:#define EO_ALIGN_SIZE(size) eina_mempool_alignof(size)
lib/eina/eina_cow.c:120: eina_mempool_alignof(sizeof (Eina_Cow_Ptr))
lib/eina/eina_cow.c:353: total_size = eina_mempool_alignof(struct_size + EINA_COW_PTR_SIZE);
lib/eina/eina_safepointer.c:372: sizeof (Eina_Memory_Entry), eina_mempool_alignof(sizeof (Eina_Memory_Entry)));
lib/eina/eina_safepointer.c:374: sizeof (Eina_Memory_Table), eina_mempool_alignof(sizeof (Eina_Memory_Table)));
lib/eina/eina_abi.c:34:eina_mempool_alignof(unsigned int size)
lib/eina/eina_mempool.h:222:static inline unsigned int eina_mempool_alignof(unsigned int size);
lib/eina/eina_inline_mempool.x:120:eina_mempool_alignof(unsigned int size)
modules/eina/mp/chained_pool/eina_chained_mempool.c:565: mp->item_alloc = MAX(eina_mempool_alignof(item_size), sizeof(void *));
modules/eina/mp/chained_pool/eina_chained_mempool.c:654: aligned_chained_pool = eina_mempool_alignof(sizeof(Chained_Pool));
modules/eina/mp/one_big/eina_one_big.c:291: pool->item_size = eina_mempool_alignof(item_size);
tests/eina/eina_test_abi.c:47:EAPI unsigned int eina_mempool_alignof(unsigned int size);
tests/eina/eina_test_abi.c:254: fail_if(eina_mempool_alignof(6) != 8);
tests/eina/eina_test_abi.c:255: fail_if((eina_mempool_alignof(10) & 0x7) != 0);

lib/eo/eo.c:1615: EO_ALIGN_SIZE(klass->parent->desc->data_size);
lib/eo/eo.c:1656: extn_data_off += EO_ALIGN_SIZE(klass->desc->data_size);
lib/eo/eo.c:1667: extn_data_off += EO_ALIGN_SIZE(extn_data_itr->klass->desc->data_size);
lib/eo/eo.c:2312: _eo_sz = EO_ALIGN_SIZE(sizeof(_Eo_Object));
lib/eo/eo.c:2313: _eo_class_sz = EO_ALIGN_SIZE(sizeof(_Efl_Class));
lib/eo/eo_ptr_indirection.x:247:#define EO_ALIGN_SIZE(size) eina_mempool_alignof(size)

This revision now requires changes to proceed.Jun 25 2019, 5:35 AM
zmike requested changes to this revision.Jun 25 2019, 6:11 AM
zmike added a subscriber: zmike.

Functions in this file can't be removed. The file exists solely to contain functions which must be kept for ABI compatibility.

JongminLee abandoned this revision.Jun 25 2019, 2:33 PM

Okay, I see. I abandon this commit.