Page MenuHomePhabricator

edje: pass stringshared part names to internal functions, specify stringshare type
AbandonedPublic

Authored by zmike on Fri, Jun 28, 12:29 PM.

Details

Reviewers
cedric
Summary

the stringshare type is the same as const char* but provides a hint to readers
that this function expects the string to already be stringshared

no functional changes
Depends on D9206

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 12004
zmike created this revision.Fri, Jun 28, 12:29 PM
cedric requested changes to this revision.Fri, Jun 28, 3:12 PM

Hum, I don't think that rp->part->name is a stringshare technically. I believe it is a unique pointer for that file inside its mmaped data.

This revision now requires changes to proceed.Fri, Jun 28, 3:12 PM

As a newcomer to stringshares this confused me. Why didn't we use Eina_Stringshare * everywhere instead of const char * from the beginning?

zmike abandoned this revision.Mon, Jul 1, 6:07 AM