Page MenuHomePhabricator

edje: change 'user_defined' member of Edje struct to be a hash
ClosedPublic

Authored by zmike on Fri, Jun 28, 12:30 PM.

Details

Summary

this is where all user-added data (e.g., swallowed objects, table/box packs,
text strings) are stored. with this patch, it is now a hash by part name,
storing a list of user-defined data for that part

this simplifies a bit of code by deconstructing some list walks, and
should end up being slightly faster for large edje objects with lots of
user-defined data

ideally no functional changes

Depends on D9206

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Fri, Jun 28, 12:30 PM
zmike requested review of this revision.Fri, Jun 28, 12:30 PM
cedric requested changes to this revision.Fri, Jun 28, 3:18 PM
cedric added inline comments.
src/lib/edje/edje_load.c
1601

Could you add another block of {} below this macro?

1929

Same here.

This revision now requires changes to proceed.Fri, Jun 28, 3:18 PM
zmike updated this revision to Diff 23122.Mon, Jul 8, 9:11 AM
zmike edited the summary of this revision. (Show Details)

merge from github

cedric accepted this revision.Wed, Jul 10, 10:33 AM
This revision is now accepted and ready to land.Wed, Jul 10, 10:33 AM
This revision was automatically updated to reflect the committed changes.