Page MenuHomePhabricator

edje: improve user-defined data caching to handle data before file is set
ClosedPublic

Authored by zmike on Fri, Jun 28, 12:32 PM.

Details

Summary

this adds explicit handling for things like:

efl_add(SOMECLASS, parent,

efl_text_set(efl_added, "my text")

);

on edje-inheriting objects.

note that it's still impossible to do something like
efl_add(SOMECLASS, parent,

efl_text_set(efl_part(efl_added, "somepart"), "my text")

);

also add a unit test to verify common behaviors

@feature

Depends on D9209

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Fri, Jun 28, 12:32 PM
cedric requested changes to this revision.Fri, Jun 28, 3:24 PM

Could you clarify the commit message to explain that all edje part API are going to "work" when a file is not set yet.

This revision now requires changes to proceed.Fri, Jun 28, 3:24 PM
zmike updated this revision to Diff 23124.Mon, Jul 8, 9:11 AM
zmike edited the summary of this revision. (Show Details)

merge from github

bu5hm4n added a subscriber: bu5hm4n.Tue, Jul 9, 7:11 AM

Lets say we have a implementation that is implementing efl_text_set internally just as setting it on a part, will that work?

zmike added a comment.Tue, Jul 9, 8:20 AM

As in the commit log, if the layout has been loaded then it can be set.

Uhm, that means, that it actaully depends on the implementation if efl_text_set works before finalize or not ? That is ... kind of an issue.

zmike added a comment.Tue, Jul 9, 8:30 AM

See the test.

cedric accepted this revision.Wed, Jul 10, 10:37 AM
This revision is now accepted and ready to land.Wed, Jul 10, 10:37 AM
This revision was automatically updated to reflect the committed changes.