Page MenuHomePhabricator

edje: fix some small leaks when failing to reapply user-defined data
ClosedPublic

Authored by zmike on Fri, Jun 28, 12:32 PM.

Details

Summary

this only occurs when the same text parts don't exist in the new layout,
which is an extremely unlikely scenario

Depends on D9210

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Fri, Jun 28, 12:32 PM
zmike requested review of this revision.Fri, Jun 28, 12:32 PM
cedric requested changes to this revision.Fri, Jun 28, 3:25 PM
cedric added inline comments.
src/lib/edje/edje_load.c
1632–1633

Don't you need to add a break here?

This revision now requires changes to proceed.Fri, Jun 28, 3:25 PM
zmike updated this revision to Diff 23125.Mon, Jul 8, 9:12 AM
zmike edited the summary of this revision. (Show Details)

merge from github

bu5hm4n requested changes to this revision.Tue, Jul 9, 7:08 AM
bu5hm4n added a subscriber: bu5hm4n.

Same question as cedric.

This revision now requires changes to proceed.Tue, Jul 9, 7:08 AM
zmike requested review of this revision.Tue, Jul 9, 8:19 AM

There is a break.

This is rather new stuff for me, so bare with me.

src/lib/edje/edje_load.c
1641

Shouldn't we also free here some texts ?

zmike added inline comments.Tue, Jul 9, 8:33 AM
src/lib/edje/edje_load.c
1641

No, there's nothing to free.

bu5hm4n accepted this revision.Tue, Jul 9, 8:41 AM
cedric accepted this revision.Wed, Jul 10, 10:35 AM
This revision is now accepted and ready to land.Wed, Jul 10, 10:35 AM
This revision was automatically updated to reflect the committed changes.