src/lib/ector/ector_renderer_image.eo
9	How about using Ector_Buffer? ector_renderer_image_buffer_set(image, Ector_buffer);
src/lib/ector/software/ector_renderer_software_image.c
98	Return as soon as possible. if (pd->opacity == 0) return true;

This revision now requires changes to proceed.Jul 10 2019, 9:43 PM

Update code that using Ector.Buffer

Harbormaster completed remote builds in B12305: Diff 23486.Jul 17 2019, 7:00 PM

update code

Harbormaster completed remote builds in B12308: Diff 23489.Jul 17 2019, 7:12 PM

Please check a comment.

src/lib/ector/ector_renderer_image.eo
4	Should it extend efl.gfx.image? I think it's not proper to extend efl_gfx_image since this ector renderer image doesn't work for its interfaces.

This revision now requires changes to proceed.Jul 17 2019, 10:22 PM

jsuya added a child revision: D9351: evas_vg_json: Add image embedded example.Jul 17 2019, 11:08 PM

remove unnecessary code

Harbormaster completed remote builds in B12311: Diff 23492.Jul 17 2019, 11:23 PM

jsuya marked an inline comment as done.Jul 17 2019, 11:24 PM

Hermet accepted this revision.Jul 21 2019, 9:28 PM

This revision is now accepted and ready to land.Jul 21 2019, 9:28 PM

Closed by commit rEFL1ce14bc85d87: Ector.Renderer : Implement Ector.Renderer.(Software).Image class (authored by jsuya, committed by Hermet). · Explain WhyJul 21 2019, 9:35 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/lib/ector/ector_private.h (6 lines)
M		src/lib/ector/ector_renderer.h (1 line)
A	M	src/lib/ector/ector_renderer_image.c (22 lines)
A	M	src/lib/ector/ector_renderer_image.eo (16 lines)
M		src/lib/ector/meson.build (2 lines)
M		src/lib/ector/software/Ector_Software.h (1 line)
A	M	src/lib/ector/software/ector_renderer_software_image.c (194 lines)
A	M	src/lib/ector/software/ector_renderer_software_image.eo (13 lines)
M		src/lib/ector/software/ector_software_surface.c (2 lines)
M		src/lib/ector/software/meson.build (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23068	229b363		Jul 7 2019, 7:14 PM	★	★
Diff 2	23486	f331d1c	Update code that using Ector.Buffer	Jul 17 2019, 7:00 PM	★	★
Diff 3	23489	f331d1c	update code	Jul 17 2019, 7:11 PM	★	★
Diff 4	23492	f331d1c	remove unnecessary code	Jul 17 2019, 11:23 PM	★	★
Diff 5	23545	de5eea2	rEFL1ce14bc85d87ece9b2e50204f1834ec5a2d0f4a1	Jul 21 2019, 9:29 PM	★	★

Ector.Renderer : Implement Ector.Renderer.(Software).Image class
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 23486

src/lib/ector/ector_private.h

src/lib/ector/ector_renderer.h

src/lib/ector/ector_renderer_image.c

src/lib/ector/ector_renderer_image.eo

src/lib/ector/meson.build

src/lib/ector/software/Ector_Software.h

src/lib/ector/software/ector_renderer_software_image.c

src/lib/ector/software/ector_renderer_software_image.eo

src/lib/ector/software/ector_software_surface.c

src/lib/ector/software/meson.build

Ector.Renderer : Implement Ector.Renderer.(Software).Image classClosedPublicActions