Page MenuHomePhabricator

efl_ui_spin_button: add test suite
ClosedPublic

Authored by bu5hm4n on Jul 7 2019, 11:09 PM.

Details

Summary

this adds a testsuite to emulate and check the usage of buttons in the
spin button widget. This also verifies that the correct events are
emitted. (For now, the testcases from spin are also copied over, since
they inherit from each other)

Depends on D9231

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jul 7 2019, 11:09 PM
bu5hm4n requested review of this revision.Jul 7 2019, 11:09 PM
zmike requested changes to this revision.Jul 8 2019, 5:55 AM
zmike added inline comments.
src/tests/elementary/efl_ui_test_spin_button.c
27

This flag should be asserted to be false before setting it to true.

36

This flag should be asserted to be false before setting it to true.

This revision now requires changes to proceed.Jul 8 2019, 5:55 AM
bu5hm4n updated this revision to Diff 23116.Jul 8 2019, 7:58 AM
bu5hm4n edited the summary of this revision. (Show Details)

assert asserts

zmike requested changes to this revision.Jul 8 2019, 10:12 AM

Good tests.

src/tests/elementary/efl_ui_test_spin_button.c
19

This should never be in a fixture. Fixtures are essentially undebuggable, so if anything ever occurs during main loop iteration then it's a pita to debug.

86

Is there a reason to set these back to false?

This revision now requires changes to proceed.Jul 8 2019, 10:12 AM
zmike accepted this revision.Jul 8 2019, 10:46 AM
This revision is now accepted and ready to land.Jul 8 2019, 10:46 AM
Closed by commit rEFL52adb65aeacc: efl_ui_spin_button: add test suite (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 8 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.