efl_ui_spin_button: add test suite
ClosedPublic
Actions

Authored by bu5hm4n on Jul 7 2019, 11:09 PM.

Details

Reviewers

CHAN
zmike
segfaultxavi

Commits

rEFL52adb65aeacc: efl_ui_spin_button: add test suite

Summary

this adds a testsuite to emulate and check the usage of buttons in the
spin button widget. This also verifies that the correct events are
emitted. (For now, the testcases from spin are also copied over, since
they inherit from each other)

Depends on D9231

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Jul 7 2019, 11:09 PM

Herald added a project: efl. · View Herald TranscriptJul 7 2019, 11:09 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

bu5hm4n requested review of this revision.Jul 7 2019, 11:09 PM

Harbormaster completed remote builds in B12040: Diff 23090.Jul 7 2019, 11:10 PM

bu5hm4n mentioned this in T7897: efl.ui.spin.Jul 7 2019, 11:44 PM

zmike requested changes to this revision.Jul 8 2019, 5:55 AM

zmike added inline comments.

src/tests/elementary/efl_ui_test_spin_button.c
27	This flag should be asserted to be false before setting it to true.
36	This flag should be asserted to be false before setting it to true.

This revision now requires changes to proceed.Jul 8 2019, 5:55 AM

assert asserts

Harbormaster completed remote builds in B12060: Diff 23116.Jul 8 2019, 7:58 AM

Good tests.

src/tests/elementary/efl_ui_test_spin_button.c
19	This should never be in a fixture. Fixtures are essentially undebuggable, so if anything ever occurs during main loop iteration then it's a pita to debug.
86	Is there a reason to set these back to false?

This revision now requires changes to proceed.Jul 8 2019, 10:12 AM

Harbormaster completed remote builds in B12071: Diff 23128.Jul 8 2019, 10:37 AM

zmike accepted this revision.Jul 8 2019, 10:46 AM

This revision is now accepted and ready to land.Jul 8 2019, 10:46 AM

Closed by commit rEFL52adb65aeacc: efl_ui_spin_button: add test suite (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 8 2019, 10:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/lib/elementary/Efl_Ui.h (1 line)
M		src/tests/elementary/efl_ui_suite.h (1 line)
M		src/tests/elementary/efl_ui_suite.c (1 line)
A	M	src/tests/elementary/efl_ui_test_spin_button.c (210 lines)
M		src/tests/elementary/meson.build (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23090	7e2b546		Jul 7 2019, 11:09 PM	★	★
Diff 2	23116	6864b36	assert asserts	Jul 8 2019, 7:58 AM	★	★
Diff 3	23128	e104906		Jul 8 2019, 10:37 AM	★	★
Diff 4	23141	d5df7e4	rEFL52adb65aeaccf54e700e8421daf59e10568df4dd	Jul 8 2019, 10:56 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D9232 efl_ui_spin_button: add test suite
Closed	bu5hm4n	D9231 efl_ui_spin_button: fix event calling in spin_button
Closed	bu5hm4n	D9230 efl_ui_spin_button: make theme consistent
Closed	bu5hm4n	D9229 efl_ui_spin_button: cleanup internal data
Closed	bu5hm4n	D9227 efl_ui_spin_button: simplify entry showing
Closed	bu5hm4n	D9226 efl_ui_spin_button: fix visibility change of entry on press
Closed	bu5hm4n	D9225 efl_ui_spin_button: remove elm_layout_sizing_eval implementation
Closed	bu5hm4n	D9224 efl_ui_spin_button: replace timers with autorepeat of button
Closed	bu5hm4n	D9242 efl_ui_spec_suite: introduce two new test suites
Closed	bu5hm4n	D9241 efl_ui_*: get range users onto the same semantics
Closed	bu5hm4n	D9221 efl_ui_spin: add tests for basic spin features