Page MenuHomePhabricator

meson: Add an meson option 'elm' to enable/disable elementary in efl
Needs RevisionPublic

Authored by smohanty on Jul 8 2019, 1:12 AM.

Details

Summary
Added to improve build time when only working in evas. as well as
a good test case to see if dependencies are correctly handled in the project.
Test Plan

Tested both enabling and disabling the option.

Diff Detail

Repository
rEFL core/efl
Branch
elm
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12042
Build 8857: arc lint + arc unit
smohanty created this revision.Jul 8 2019, 1:12 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

smohanty requested review of this revision.Jul 8 2019, 1:12 AM
bu5hm4n requested changes to this revision.Jul 8 2019, 2:20 AM

I am not sure what the goal of this patch is, reducing the build times when you are only working in evas can also be achieved with only building evas using ninja src/lib/evas_goal/libevas.so.1.22.99. in-tree running of not rebuild binaries should still just continue to work, as long as no internal APIs are changed. Additionally, as long as you do not touch any .eo / .h file, elementary should not be forced to be rebuild...

Additionally:

  • Build break in documentation creation.
  • efl-ui.pc is also still installed, even if there is no library like this.
  • The CMakeConfig files are also still installed.
  • Build break in the C# bindings

This also opens up a whole new set of problems, how do we garantee that noone builds a efl release without elm? Elm is a part of EFL! if there is a configure option, someone will use it. Who will maintain this option, and guarantee that it will not break in future ?

This revision now requires changes to proceed.Jul 8 2019, 2:20 AM
Hermet requested changes to this revision.Jul 8 2019, 10:20 PM

@smohanty any special purpose for this? efl is going to integrate one unified set.