Page MenuHomePhabricator

Ector.Renderer: Prevent too many unref.
ClosedPublic

Authored by jsuya on Jul 8 2019, 1:16 AM.

Details

Summary

pd-> surface will try efl_xref whenever surface_set is called.
desturctor is called from a subclass, ref and unref do not match.
So, Add this condition temporarily.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Jul 8 2019, 1:16 AM
jsuya requested review of this revision.Jul 8 2019, 1:16 AM
Hermet accepted this revision.Jul 8 2019, 10:12 PM
This revision is now accepted and ready to land.Jul 8 2019, 10:12 PM
Hermet requested changes to this revision.Jul 8 2019, 10:16 PM

Maybe we can replace xref with just efl_ref()

This revision now requires changes to proceed.Jul 8 2019, 10:16 PM
Hermet accepted this revision.Jul 8 2019, 11:46 PM

Though it's workaround, i think it's better than the current.

This revision is now accepted and ready to land.Jul 8 2019, 11:46 PM
This revision was automatically updated to reflect the committed changes.