Page MenuHomePhabricator
Differential D9237

eolian_cxx: update eolian_cxx to recognize slice and rw_slice
ClosedPublic
Actions

Authored by vitor.sousa on Jul 8 2019, 7:13 AM.

Details

Reviewers
lauromoura
felipealmeida
q66
Commits
rEFL5ae9e04e4ded: eolian_cxx: update eolian_cxx to recognize slice and rw_slice
Summary

Update eolian_cxx to recognize the new keywords slice and rw_slice, so it
can generate the corresponding types Eina_Slice and Eina_Rw_Slice.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vitor.sousa created this revision.Jul 8 2019, 7:13 AM
vitor.sousa requested review of this revision.Jul 8 2019, 7:13 AM
q66 accepted this revision.Jul 8 2019, 7:15 AM

But the proper thing to do later on would be to create a wrapper type with the same layout as Eina_Slice (or Eina_Rw_Slice) but make it templated in order to respect Eolian's typeinfo. But for now this is fine

This revision is now accepted and ready to land.Jul 8 2019, 7:15 AM
Closed by commit rEFL5ae9e04e4ded: eolian_cxx: update eolian_cxx to recognize slice and rw_slice (authored by vitor.sousa, committed by q66). · Explain WhyJul 8 2019, 7:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23113

View Options

src/lib/eolian_cxx/grammar/type_impl.hpp

Loading...