Page MenuHomePhabricator

efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface.
Needs ReviewPublic

Authored by Hermet on Wed, Jul 10, 4:23 AM.

Details

Reviewers
kimcinoo
jsuya
Group Reviewers
committers
Summary

This patch revises efl_ui_textpath_circle_set() interface.

Current circle_set() behavior is wrongly working,
it makes object minimal size with (x * 2, y * 2).
Insanely, how big size if the object is far from the screen origin.

Secondly, current interface requires center position,
How this center position could be guranteed if user wants to put it into a container?

Third, actual textpath output could be out of the textpath boundary,
since the textpath is originated to middle of text height.
the display boundary can be outside of the textpath geometry by (half of text height).

All in all, put altogether in fix,
I confirmed there is no methods without any compatibility break.

This brings elm_textpath_circular_set() api introduced.

@feature

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12094
Build 8877: arc lint + arc unit
Hermet created this revision.Wed, Jul 10, 4:23 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Hermet requested review of this revision.Wed, Jul 10, 4:23 AM

I'm curious, Efl.Ui.Textpath only allows circular text? If this is the case, shouldn't it be called something like Efl.Ui.Text_Circle?
I'm asking because Textpath seems to indicate that any path is possible, but I see no way to do that with this API.

With its current functionality, I think this class should be named Efl.Ui.Text_Circle and the property should be radius.

Or is this widgwt capable of drawing other shapes? @Hermet? @zmike? @bu5hm4n?

With its current functionality, I think this class should be named Efl.Ui.Text_Circle and the property should be radius.

Or is this widgwt capable of drawing other shapes? @Hermet? @zmike? @bu5hm4n?

@segfaultxavi yes't basically, it allows other shapes since its implementing efl_gfx_path.
for other shapes, you could use efl_gfx_path interfaces directly though it's not tested at all.
this circular api is just for convenient.

Ah, OK, now I understand, thank you very much. Disregard my comment then.