Page MenuHomePhabricator

efl_ui_item: rework parent relation
ClosedPublic

Authored by bu5hm4n on Jul 10 2019, 7:41 AM.

Details

Summary

this commit ensures that there is a public way of setting the container
to a item. This was also like this before, just with the difference that
it was set and unset in all privacy, however, we want to have this class
also ready for bindings, so we should stop making things privat like
this.

Note: the removed fields from grid and list have not been used.

ref T7905

Diff Detail

Repository
rEFL core/efl
Branch
devs/bu5hm4n/work_items
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 12138
bu5hm4n created this revision.Jul 10 2019, 7:41 AM
bu5hm4n requested review of this revision.Jul 10 2019, 7:41 AM

hmm so this is the way you want to say the container widget before it packed... interesting..
so what if user forcely change the container after packed?
shouldn't we call the unpack or something?

The API should only be called by the container, never by the API, i will add such a outline to the .eo file.

bu5hm4n updated this revision to Diff 23240.Jul 11 2019, 3:57 AM
bu5hm4n edited the summary of this revision. (Show Details)

add note about container property

SanghyeonLee accepted this revision.Jul 11 2019, 4:10 AM

if it only need to be called by the container... is there any reason that it need to be eo API?
hmm... I think the patch is aceeptable but don't know it need to be a public.

This revision is now accepted and ready to land.Jul 11 2019, 4:10 AM

It *needs* to be public, otherwise, noone can use the items from outside efl in the bindings, and that is our maingoal here.

oh okay.. to get their parent, make sense.
although mr taehyup working on some abstract c# items which wrapping the efl.ui.item without edje layout... still it seems helpful.
thank you.

Closed by commit rEFLd30fc5f5d3a1: efl_ui_item: rework parent relation (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 11 2019, 4:30 AM
This revision was automatically updated to reflect the committed changes.