Page MenuHomePhabricator

efl_ui_item: remove internal pointer to select_mode
ClosedPublic

Authored by bu5hm4n on Jul 10 2019, 8:05 AM.

Details

Summary

there was this internal pointer to select_mode for getting the selection
mode of the container. However, we now have API for checking this, so
there is exactly 0 reason for doing this like this. Additionally, with
the old way of doing, bildings like C# or lua are just lost, they cannot
use this class at all in there implementations, as they cannot access
the privat data.

ref T7905
Depends on D9262

Diff Detail

Repository
rEFL core/efl
Branch
devs/bu5hm4n/work_items
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 12098
bu5hm4n created this revision.Jul 10 2019, 8:05 AM
bu5hm4n requested review of this revision.Jul 10 2019, 8:05 AM
zmike requested changes to this revision.Jul 10 2019, 10:19 AM

wrong ticket ref

This revision now requires changes to proceed.Jul 10 2019, 10:19 AM
bu5hm4n edited the summary of this revision. (Show Details)Jul 10 2019, 10:46 AM
bu5hm4n added a reviewer: SanghyeonLee.
bu5hm4n requested review of this revision.Jul 10 2019, 11:18 AM
zmike resigned from this revision.Jul 10 2019, 12:24 PM

Seems okay.

SanghyeonLee accepted this revision.Jul 11 2019, 3:47 AM

the patch looks correct fix.

This revision is now accepted and ready to land.Jul 11 2019, 3:47 AM
Closed by commit rEFLd512ff68ae41: efl_ui_item: remove internal pointer to select_mode (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 11 2019, 4:30 AM
This revision was automatically updated to reflect the committed changes.