Page MenuHomePhabricator

efl: use eina_streq for all property operation in model to avoid crash on NULL property name.
ClosedPublic

Authored by cedric on Jul 10 2019, 11:48 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jul 10 2019, 11:48 AM
cedric requested review of this revision.Jul 10 2019, 11:48 AM

It seems to me like there should never be NULL strings/properties in an iterator.

bu5hm4n accepted this revision.Jul 10 2019, 12:06 PM

@zmike are you okay with keeping this just as "safe practice" ? I do not see an issue with having one NULL check too much.

This revision is now accepted and ready to land.Jul 10 2019, 12:06 PM

I didn't reject it, I just think it's weird to imply this.

Closed by commit rEFLfce5645d804a: efl: use eina_streq for all property operation in model to avoid crash on NULL… (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 10 2019, 12:10 PM
This revision was automatically updated to reflect the committed changes.