efl: use eina_streq for all property operation in model to avoid crash on NULL property name.
ClosedPublic
Actions

Authored by cedric on Jul 10 2019, 11:48 AM.

Details

Reviewers

Maniphest Tasks

T7376: [MVVM] Model Selection Support

Commits

Summary

Depends on D8570

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric requested review of this revision.Jul 10 2019, 11:48 AM

It seems to me like there should never be NULL strings/properties in an iterator.

@zmike are you okay with keeping this just as "safe practice" ? I do not see an issue with having one NULL check too much.

This revision is now accepted and ready to land.Jul 10 2019, 12:06 PM

I didn't reject it, I just think it's weird to imply this.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/ecore/efl_composite_model.c (6 lines)
M			src/lib/ecore/efl_filter_model.c (2 lines)
M			src/lib/ecore/efl_loop_model.c (2 lines)
M			src/lib/ecore/efl_select_model.c (12 lines)
M			src/lib/eio/efl_io_model.c (8 lines)
M			src/lib/eldbus/eldbus_model.c (4 lines)
M			src/lib/eldbus/eldbus_model_object.c (2 lines)
M			src/lib/elementary/efl_ui_average_model.c (8 lines)
M			src/lib/elementary/efl_ui_exact_model.c (24 lines)
M			src/lib/elementary/efl_ui_homogeneous_model.c (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23211	13b6382		Jul 10 2019, 11:48 AM	★	★
Diff 2	23214	4e4210b	rEFLfce5645d804a8971dd27542c979dd27a7aa8bc1a	Jul 10 2019, 12:10 PM	★	★

Status	Author	Revision
Closed	cedric	D9266 efl: use eina_streq for all property operation in model to avoid crash on NULL property name.
Closed	cedric	D8570 ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information.
Closed	cedric	D8569 ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value.
Closed	cedric	D8568 ecore: move property string definition to shared headers for Efl.Composite_Model.