Page MenuHomePhabricator

efl: implement notification for when the model is changed on a widget.
ClosedPublic

Authored by cedric on Thu, Jul 11, 4:06 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Thu, Jul 11, 4:06 PM
cedric requested review of this revision.Thu, Jul 11, 4:06 PM
bu5hm4n requested changes to this revision.Fri, Jul 12, 3:24 AM

Please add a spec test for this, which checks it on everything that implements on Efl.Ui.View.

This revision now requires changes to proceed.Fri, Jul 12, 3:24 AM
bu5hm4n added inline comments.Fri, Jul 12, 3:33 AM
src/lib/elementary/efl_ui_widget.c
5792

Just as a question, why "return ;" and not "return;" ?

5833

Can you elaborate why this call here is needed?

Please add a spec test for this, which checks it on everything that implements on Efl.Ui.View.

Nice idea.

src/lib/elementary/efl_ui_widget.c
5792

A long time habit as return is a keyword and we add space after keyword like if, for, while, that happens.

5833

A model can be set on an object, but until you bind anything to it, there is no need to actually watch the property change on the model. So we do that call for this to happen (Model_Lookup exist when doing this call for the first time).

cedric planned changes to this revision.Fri, Jul 12, 9:18 AM
bu5hm4n accepted this revision.Sun, Jul 14, 12:40 PM
This revision is now accepted and ready to land.Sun, Jul 14, 12:40 PM
Closed by commit rEFL4d071ff1cbc0: efl: implement notification for when the model is changed on a widget. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Jul 17, 12:59 PM
This revision was automatically updated to reflect the committed changes.