Page MenuHomePhabricator

ecore: remove efl_loop_{un,}register from .eo.
ClosedPublic

Authored by cedric on Thu, Jul 11, 4:23 PM.

Details

Summary

We have to keep this as an API, but binding do not need to see it at this point.

Depends on D9296

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Thu, Jul 11, 4:23 PM
cedric requested review of this revision.Thu, Jul 11, 4:23 PM
bu5hm4n requested changes to this revision.Fri, Jul 12, 4:20 AM

I would prefer to just keep this or move it outside the .eo file. I mean, we have added that a release back, i do not want to drop it now. Better deprecate it, then we at least do not kill hope in the new API.

This revision now requires changes to proceed.Fri, Jul 12, 4:20 AM
zmike requested changes to this revision.Fri, Jul 12, 5:53 AM

We can remove this from eolian to make it unavailable for bindings, but we can only deprecate it until 2.0.

cedric planned changes to this revision.Fri, Jul 12, 8:55 AM
In D9297#171570, @zmike wrote:

We can remove this from eolian to make it unavailable for bindings, but we can only deprecate it until 2.0.

Make sense.

cedric updated this revision to Diff 23344.Fri, Jul 12, 12:58 PM
cedric retitled this revision from ecore: remove efl_loop_{un,}register. to ecore: remove efl_loop_{un,}register from .eo..
cedric edited the summary of this revision. (Show Details)

Rebase and take comment into account.

bu5hm4n accepted this revision.Sun, Jul 14, 12:46 PM

Looks okay to me, we just go with the risk that *someone* might still can overwrite it. Its still in the vtable, we could also just make it a plain function that calls the efl_object API. But maybe thats just be being over carefull.

zmike accepted this revision.Mon, Jul 15, 12:38 PM
This revision is now accepted and ready to land.Mon, Jul 15, 12:38 PM
Closed by commit rEFL83700fe13c49: ecore: remove efl_loop_{un,}register from .eo. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Jul 17, 12:59 PM
This revision was automatically updated to reflect the committed changes.