Page MenuHomePhabricator

Rename orientation -> image_orientation.
ClosedPublic

Authored by eagleeye on Thu, Jul 11, 9:43 PM.

Details

Summary

Efl.Gfx.Image_Orientable and Efl.Ui.Layout_Orientable have same property name.
So when class extends both interfaces, it makes conflict.

Relates to T7924

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eagleeye created this revision.Thu, Jul 11, 9:43 PM
eagleeye requested review of this revision.Thu, Jul 11, 9:43 PM
eagleeye edited the summary of this revision. (Show Details)Thu, Jul 11, 9:47 PM
eagleeye added a reviewer: segfaultxavi.
segfaultxavi accepted this revision.Fri, Jul 12, 1:31 AM

Makes sense, builds and passes tests, and allows scrollbar to inherit both from Layout_Orientable and Image_Orientable.

Thanks for this patch. For consistency, could you also rename Efl.Ui.Layout_Orientable.orientation to layout_orientation?

This revision is now accepted and ready to land.Fri, Jul 12, 1:31 AM
Closed by commit rEFL7d33cf977f51: Rename orientation -> image_orientation. (authored by Hosang Kim <hosang12.kim@samsung.com>, committed by segfaultxavi). · Explain WhyFri, Jul 12, 1:32 AM
This revision was automatically updated to reflect the committed changes.