Page MenuHomePhabricator

efl_ui/scroll_manager: mimic feel of legacy scroller

Authored by zmike on Jul 18 2019, 6:22 AM.



previously this used a hard linear scroll with a fixed animation time for
mouse wheel events, resulting in an unnatural scroll feel due to abrupt
animation termination

using the decelerate interpolator improves this, and we should be using the
config to determine animation speed
Depends on D9347

Diff Detail

rEFL core/efl
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jul 18 2019, 6:22 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added:

zmike requested review of this revision.Jul 18 2019, 6:22 AM

Can you propose a test plan so I can check whether this works or not? I see no difference in scrolling animation with or without this patch.

zmike added a comment.Jul 22 2019, 8:25 AM

Run the legacy and ui "simple" scroller tests and watch the end of the scrolling animation carefully.

segfaultxavi accepted this revision.Jul 22 2019, 8:38 AM

Works as advertised. My problem was a corrupted settings file, apparently.

This revision is now accepted and ready to land.Jul 22 2019, 8:38 AM
This revision was automatically updated to reflect the committed changes.