efl_ui/scroll_manager: mimic feel of legacy scroller
ClosedPublic
Actions

Authored by zmike on Jul 18 2019, 6:22 AM.

Details

Reviewers

bu5hm4n
segfaultxavi

Commits

rEFL47423ab72064: efl_ui/scroll_manager: mimic feel of legacy scroller

Summary

previously this used a hard linear scroll with a fixed animation time for
mouse wheel events, resulting in an unnatural scroll feel due to abrupt
animation termination

using the decelerate interpolator improves this, and we should be using the
config to determine animation speed
Depends on D9347

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Jul 18 2019, 6:22 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Jul 18 2019, 6:22 AM

Harbormaster completed remote builds in B12316: Diff 23498.Jul 18 2019, 6:23 AM

zmike added reviewers: bu5hm4n, segfaultxavi.Jul 22 2019, 5:50 AM

Can you propose a test plan so I can check whether this works or not? I see no difference in scrolling animation with or without this patch.

Run the legacy and ui "simple" scroller tests and watch the end of the scrolling animation carefully.

Works as advertised. My problem was a corrupted settings file, apparently.

This revision is now accepted and ready to land.Jul 22 2019, 8:38 AM

Closed by commit rEFL47423ab72064: efl_ui/scroll_manager: mimic feel of legacy scroller (authored by zmike, committed by segfaultxavi). · Explain WhyJul 22 2019, 8:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/elementary/efl_ui_scroll_manager.c (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23498	448ade3		Jul 18 2019, 6:22 AM	★	★
Diff 2	23567	a26c787	rEFL47423ab72064309d5a8e0824ab9f3761e11666e8	Jul 22 2019, 8:39 AM	★	★

Status	Author	Revision
Closed	zmike	D9354 efl_ui/scroll_manager: mimic feel of legacy scroller
Closed	zmike	D9347 elm_test: add efl.ui.scroller test with big table
Closed	zmike	D9346 efl_ui/table: optimize position_set operations with tables
Closed	zmike	D9345 elm_test: rename efl.ui.scroller simple test function name
Closed	zmike	D9344 efl_ui/table: avoid exploding stack with lots of subobjects
Closed	zmike	D9336 evas/box: avoid triggering smart_move callback

Diff 23567

View Options

src/lib/elementary/efl_ui_scroll_manager.c