Page MenuHomePhabricator

efl_ui_layout: set needs_size_calc flag at constructor
ClosedPublic

Authored by akanad on Jul 19 2019, 9:21 PM.

Details

Summary

even if there is a min definition on theme for some object,
the objects don't have the min size if we do nothing after creating it.

elm_layout_sizing_eval will return with doing nothing while executing contructor
so that _sizing_eval in _layout_group_calculate will never be invoked without calling hint_set, text_set, content_set, etc.

this patch modifies a initial state of needs_size_calc flag
so that object will doing _sizing_eval after executing constructor.

Test Plan
  1. remove lines that call apis such as content_set, hint_set, text_set in radio test on elementary_test
  1. observe that radios don't have min size

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akanad created this revision.Jul 19 2019, 9:21 PM
akanad requested review of this revision.Jul 19 2019, 9:21 PM
akanad edited the summary of this revision. (Show Details)Jul 22 2019, 3:06 AM
zmike accepted this revision.Jul 22 2019, 6:08 AM
This revision is now accepted and ready to land.Jul 22 2019, 6:08 AM
This revision was automatically updated to reflect the committed changes.