efl_ui_range_display: move events from spin
ClosedPublic
Actions

Authored by bu5hm4n on Jul 22 2019, 4:13 AM.

Details

Reviewers

segfaultxavi
zmike
woohyun

Maniphest Tasks

T7895: efl.ui.range_display
T7897: efl.ui.spin

Commits

rEFLc0082b1c71ed: efl_ui_range_display: move events from spin

Summary

we concluded min,reached and max,reached should be on every widget that
implements range_display. This here is the start of that work, the
events are moved, next commit fixes all widgets, the last commits
enables tests in the spec unit test.

Thank you vitor for the cxx patch.

ref T7897
ref T7895

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Jul 22 2019, 4:13 AM

Herald added a project: efl. · View Herald TranscriptJul 22 2019, 4:13 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

bu5hm4n requested review of this revision.Jul 22 2019, 4:13 AM

bu5hm4n added a child revision: D9372: efl_ui_*: add the new events to the widgets.

Harbormaster completed remote builds in B12349: Diff 23558.Jul 22 2019, 4:14 AM

Breaks c++ examples.

../src/examples/elementary/slider_cxx_example.cc:79:8: error: ‘struct efl::ui::Slider’ has no member named ‘changed_event_cb_add’

Other than that, everything seems fine and I am willing to approve this.

This revision now requires changes to proceed.Jul 26 2019, 2:38 AM

I think i need @vitor.sousa or @felipealmeida here, why is that not working ? it also seems that i cannot cast efl::ui::Slider to efl::ui::Range_Display, do you know why ?

@bu5hm4n

Add this patch:

update_slider_cxx_example.diff990 BDownload

The eo_cxx wrappers don't use inheritance in traditional ways, since the traditional aspects of OOP are handled by C under the hood.
Performing inheritance in C++ too (at least in the traditional virtual way) would simply double the OOP overhead (two virtual table lookups).
So we opted for a "thin layer" using only static inheritance.

Now thinking of it, I think cast would be a better name to downcast.
And having a version of it that works with non-owning pointers would be desirable too.

fix cxx issue

Harbormaster completed remote builds in B12482: Diff 23755.Jul 30 2019, 9:51 AM

Everything fine now!

This revision is now accepted and ready to land.Jul 31 2019, 1:17 AM

Closed by commit rEFLc0082b1c71ed: efl_ui_range_display: move events from spin (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by segfaultxavi). · Explain WhyJul 31 2019, 1:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bin/elementary/test_evas_snapshot.c (2 lines)
M			src/bin/elementary/test_ui_box.c (14 lines)
M			src/bin/elementary/test_ui_pager.c (4 lines)
M			src/bin/elementary/test_ui_pager_scroll.c (8 lines)
M			src/bin/elementary/test_ui_relative_layout.c (6 lines)
M			src/bin/elementary/test_ui_slider.c (2 lines)
M			src/bin/elementary/test_ui_slider_interval.c (2 lines)
M			src/bin/elementary/test_ui_spin.c (6 lines)
M			src/bin/elementary/test_ui_spin_button.c (2 lines)
M			src/bin/elementary/test_ui_spotlight.c (4 lines)
M			src/bin/elementary/test_ui_table.c (12 lines)
M			src/bin/elementary/test_ui_textpath.c (4 lines)
M			src/lib/efl/interfaces/efl_ui_range_display.eo (5 lines)
M			src/lib/elementary/efl_ui_datepicker.c (6 lines)
M			src/lib/elementary/efl_ui_progressbar.c (2 lines)
M			src/lib/elementary/efl_ui_progressbar.eo (3 lines)
M			src/lib/elementary/efl_ui_slider.c (4 lines)
M			src/lib/elementary/efl_ui_slider.eo (3 lines)
M			src/lib/elementary/efl_ui_slider_interval.c (8 lines)
M			src/lib/elementary/efl_ui_spin.c (6 lines)
M			src/lib/elementary/efl_ui_spin.eo (5 lines)
M			src/lib/elementary/efl_ui_timepicker.c (4 lines)
M			src/lib/elementary/elc_player.c (4 lines)
M			src/lib/elementary/elm_slider.c (4 lines)
M			src/modules/elementary/prefs/elm_slider.c (2 lines)
M			src/tests/elementary/efl_ui_test_slider.c (6 lines)
M			src/tests/elementary/efl_ui_test_spin.c (12 lines)
M			src/tests/elementary/efl_ui_test_spin_button.c (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23558	5fd3436		Jul 22 2019, 4:13 AM	★	★
Diff 2	23755	0ab05a8	fix cxx issue	Jul 30 2019, 9:51 AM	★	★
Diff 3	23783	911eab3	rEFLc0082b1c71ed63f982bb4b9aed2af4b50d46dabe	Jul 31 2019, 1:18 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D9373 efl_ui_spec: add test suite for range_display events
Closed	bu5hm4n	D9372 efl_ui_*: add the new events to the widgets
Closed	bu5hm4n	D9371 efl_ui_range_display: move events from spin

efl_ui_range_display: move events from spinClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 23783

src/bin/elementary/test_evas_snapshot.c

src/bin/elementary/test_ui_box.c

src/bin/elementary/test_ui_pager.c

src/bin/elementary/test_ui_pager_scroll.c

src/bin/elementary/test_ui_relative_layout.c

src/bin/elementary/test_ui_slider.c

src/bin/elementary/test_ui_slider_interval.c

src/bin/elementary/test_ui_spin.c

src/bin/elementary/test_ui_spin_button.c

src/bin/elementary/test_ui_spotlight.c

src/bin/elementary/test_ui_table.c

src/bin/elementary/test_ui_textpath.c

src/lib/efl/interfaces/efl_ui_range_display.eo

src/lib/elementary/efl_ui_datepicker.c

src/lib/elementary/efl_ui_progressbar.c

src/lib/elementary/efl_ui_progressbar.eo

src/lib/elementary/efl_ui_slider.c

src/lib/elementary/efl_ui_slider.eo

src/lib/elementary/efl_ui_slider_interval.c

src/lib/elementary/efl_ui_spin.c

src/lib/elementary/efl_ui_spin.eo

src/lib/elementary/efl_ui_timepicker.c

src/lib/elementary/elc_player.c

src/lib/elementary/elm_slider.c

src/modules/elementary/prefs/elm_slider.c

src/tests/elementary/efl_ui_test_slider.c

src/tests/elementary/efl_ui_test_spin.c

src/tests/elementary/efl_ui_test_spin_button.c

efl_ui_range_display: move events from spin
ClosedPublic
Actions

Revision Contents
Changeset List