Page MenuHomePhabricator

[elm] Add missing sizing eval hook at check
ClosedPublic

Authored by subodh6129 on Jul 23 2019, 12:18 AM.

Details

Summary

check is not shown in our Tizen demo.
sizing eval missing.

@fix

Test Plan

NA

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
subodh6129 created this revision.Jul 23 2019, 12:18 AM
subodh6129 requested review of this revision.Jul 23 2019, 12:18 AM
bu5hm4n requested changes to this revision.Jul 23 2019, 12:20 AM
bu5hm4n added a subscriber: bu5hm4n.

Can you remove it again from radio then ? (63275dfef864282170e0c30d765eddf3ee41cd27)

It seems unnecessary to have it in both.

This revision now requires changes to proceed.Jul 23 2019, 12:20 AM

Can you remove it again from radio then ? (63275dfef864282170e0c30d765eddf3ee41cd27)

It seems unnecessary to have it in both.

I did not get your point I guess, both are different widgets.

Efl.Ui.Radio is inheriting from Efl.Ui.Check. In other words, Efl.Ui.Radio *is* a Efl.Ui.Check.

  • Revert "[elm] Add missing sizing eval hook at radio"
bu5hm4n accepted this revision.Jul 23 2019, 1:05 AM
This revision is now accepted and ready to land.Jul 23 2019, 1:05 AM

Thank you :)

Just as a side note, can you next time prefix your commit title either with "elm:" or "efl_ui_check/efl_ui_radio:" ? That is the normal convention we are having .

Closed by commit rEFL8c90deecd737: [elm] Add missing sizing eval hook at check (authored by subodh6129, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 23 2019, 1:07 AM
This revision was automatically updated to reflect the committed changes.

Actually I followed the old convention, its been little while since I had not contributed.

I will take care. Thanks,

Oh, that convention might have been before my time ... sorry then, this changed :)