Page MenuHomePhabricator

efl_ui_text: scroller with singleline
Needs ReviewPublic

Authored by ali.alzyod on Thu, Jul 25, 1:42 AM.

Details

Summary

this is related to T8023

Diff Detail

Repository
rEFL core/efl
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12384
Build 8982: arc lint + arc unit
ali.alzyod created this revision.Thu, Jul 25, 1:42 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Thu, Jul 25, 1:42 AM

I confirm this fixes the issue in T8023, however I won't comment on the code since I am not familiar enough with this part.

Please add a commit message explaining why this was broken and how this patch fixes it. It's good that git messages reference Phab tickets but they should be understandable without Phab access.

ali.alzyod updated this revision to Diff 23607.Thu, Jul 25, 3:51 AM

efl_ui_text: set scroll internal mode, depnding on single line mode (!multiline), It seems by default scroll internal mode is Single_Line_mode

@segfaultxavi Thanks , I added commit message.

Issue (As I see it):
When enable scrolling, we should also set the scroll internal mode, and this is depending on single line mode (!multiline in efl_ui_text), It seems by default scroll internal mode is Single_Line_mode.

But After typing scroll_internal_mode is set depending on object single line mode.