Page MenuHomePhabricator

efl_ui/popup: implement efl.file.unload for popup backwall part
ClosedPublic

Authored by zmike on Jul 26 2019, 10:02 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jul 26 2019, 10:02 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Jul 26 2019, 10:02 AM
bu5hm4n added inline comments.
src/lib/elementary/efl_ui_popup.c
360

The loading below is calling super on "MY_CLASS" which is Efl.Ui.Popup. Here it is on Popup. Not considering what is correct, but i think this should be the same ?

zmike added inline comments.Jul 29 2019, 6:26 AM
src/lib/elementary/efl_ui_popup.c
360
This revision is now accepted and ready to land.Jul 29 2019, 6:28 AM
Closed by commit rEFLa61cef3fb208: efl_ui/popup: implement efl.file.unload for popup backwall part (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 29 2019, 7:21 AM
This revision was automatically updated to reflect the committed changes.