Page MenuHomePhabricator

efl_ui_spotlight: add scroll_block to Manager_Scroll
ClosedPublic

Authored by Jaehyun_Cho on Jul 29 2019, 11:20 PM.

Details

Summary

To support blocking of scrolling movement, @property scroll_block has
been added to Manager_Scroll.
If scroll_block is set to be true, then scrolling movement by mouse
input is blocked.

Test Plan
  1. Run "Efl.Ui.Spotlight Scroll" in elementary_test
  2. Select "Scroll Block"
  3. Check "Scroll Block"
  4. Test scrolling movement by mouse input

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jaehyun_Cho created this revision.Jul 29 2019, 11:20 PM
Jaehyun_Cho requested review of this revision.Jul 29 2019, 11:20 PM

Added commit message related task T8040

bu5hm4n requested changes to this revision.Jul 29 2019, 11:48 PM

Looks good otherwise :)

src/lib/elementary/efl_ui_spotlight_manager_scroll.c
348

Can you guard that with a if (pd->mouse_move.active) ?

In case there is a transition going on which is trigger by API, then we do not want to abort that i think.

This revision now requires changes to proceed.Jul 29 2019, 11:48 PM

@bu5hm4n Thank you for the comment :) I added the condition to check if mouse move is active.

bu5hm4n accepted this revision.Jul 30 2019, 12:09 AM

Nice! I will land it later on today :)

This revision is now accepted and ready to land.Jul 30 2019, 12:09 AM
Closed by commit rEFL959c68ca2e60: efl_ui_spotlight: add scroll_block to Manager_Scroll (authored by Jaehyun_Cho, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 30 2019, 11:42 PM
This revision was automatically updated to reflect the committed changes.