Page MenuHomePhabricator

efl_ui_position_manager: move from accessor to function callback
ClosedPublic

Authored by bu5hm4n on Jul 30 2019, 3:04 AM.

Details

Summary

this commit enables access to the item structure of the collection via a
function callback. The function callback now enables batching for items,
which does not pay off right now. However, a few more optimizations can
be done in order to get the whole payoff.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jul 30 2019, 3:04 AM
bu5hm4n requested review of this revision.Jul 30 2019, 3:04 AM
segfaultxavi requested changes to this revision.Jul 30 2019, 4:26 AM
segfaultxavi added inline comments.
src/lib/elementary/efl_ui_position_manager_entity.eo
2

DOOOOOOOOOOOOOCS! FOR EVERYTHING!

42–43

Docs need to be updated (this is no longer an accessor). And since we are here, correct the "obejct" typo.
Same below.

This revision now requires changes to proceed.Jul 30 2019, 4:26 AM
bu5hm4n updated this revision to Diff 23768.Jul 30 2019, 10:45 AM
bu5hm4n edited the summary of this revision. (Show Details)

make doc cop less sad

cedric requested changes to this revision.Jul 31 2019, 10:19 AM
cedric added inline comments.
src/lib/elementary/efl_ui_position_manager_grid.c
251

This one can be a tad risky. I would feel better with a malloc and even better if all of that was capped to a max and iterated over by step in job.

src/lib/elementary/efl_ui_position_manager_list.c
264

This seems like it could be refactored between both position manager.

This revision now requires changes to proceed.Jul 31 2019, 10:19 AM
bu5hm4n updated this revision to Diff 23805.Jul 31 2019, 10:38 AM
bu5hm4n edited the summary of this revision. (Show Details)

do not use alloca

@felipealmeida This revision somehow is breaking c++ bindings, can you have a look into why ?

src/lib/elementary/efl_ui_position_manager_list.c
264

That is not really worth it. by the time you have passed all the 6 long names, its already a damn long name + long parameters. which makes it damn long...

bu5hm4n updated this revision to Diff 23808.Jul 31 2019, 11:09 AM

here comes the lost file

D9469 e D9468 are needed to fix the C++ binding bugs which this patch reproduces

cedric accepted this revision.Jul 31 2019, 2:12 PM

C++ patches are pushed

This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2019, 3:51 PM
Closed by commit rEFLd98d434e56fe: efl_ui_position_manager: move from accessor to function callback (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by cedric). · Explain Why
This revision was automatically updated to reflect the committed changes.

Thank you very much for this fast fix :)