Page MenuHomePhabricator
Differential D9453

Efl.Ui.Spin: Remove mouse wheel interaction
ClosedPublic
Actions

Authored by segfaultxavi on Jul 31 2019, 3:36 AM.

Details

Reviewers
bu5hm4n
woohyun
CHAN
Maniphest Tasks
T7897: efl.ui.spin
Commits
rEFL359a118cdaa9: Efl.Ui.Spin: Remove mouse wheel interaction
Summary

This widget is now meant as a base class for other widgets, with very limited
user interaction. Efl.Ui.Spin_Button already takes care of mouse wheel events.

Ref T7897

Test Plan

Everything builds and passes tests, and Efl.Ui.Spin widgets no longer react to moving the mouse wheel over them.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
segfaultxavi created this revision.Jul 31 2019, 3:36 AM
segfaultxavi requested review of this revision.Jul 31 2019, 3:36 AM
bu5hm4n accepted this revision.Jul 31 2019, 3:41 AM
bu5hm4n added inline comments.
src/tests/elementary/efl_ui_test_spin.c
92

For the record: this is already in spin_button tests.

This revision is now accepted and ready to land.Jul 31 2019, 3:41 AM
Closed by commit rEFL359a118cdaa9: Efl.Ui.Spin: Remove mouse wheel interaction (authored by segfaultxavi, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJul 31 2019, 3:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23792

View Options

src/lib/elementary/efl_ui_spin.c

Loading...
View Options

src/lib/elementary/efl_ui_spin.eo

Loading...
View Options

src/tests/elementary/efl_ui_test_spin.c

Loading...