Page MenuHomePhabricator

efl_ui_spin: move the step implementation to spin_button
ClosedPublic

Authored by bu5hm4n on Aug 1 2019, 5:00 AM.

Details

Summary

having efl_ui_spin implementing efl.ui.range_interactive does not make
sense. Efl.Ui.Spin is a not interactive widget, so it should not
implement that interface.

ref T7897

Depends on D9474

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Aug 1 2019, 5:00 AM
bu5hm4n requested review of this revision.Aug 1 2019, 5:00 AM
segfaultxavi accepted this revision.Aug 1 2019, 7:15 AM

Maketh sense, buildeth and paseth tests.

This revision is now accepted and ready to land.Aug 1 2019, 7:15 AM
segfaultxavi requested changes to this revision.Aug 1 2019, 7:21 AM

Actually, this break the Efl.Ui.Spin elm_test, because it is calling efl_ui_range_step_get and _set on the spin in multiple places.

This revision now requires changes to proceed.Aug 1 2019, 7:21 AM

Why was there ever a API call to it ... it was never used ...

bu5hm4n updated this revision to Diff 23871.Aug 3 2019, 2:17 AM
bu5hm4n edited the summary of this revision. (Show Details)

fix api calls

This revision is now accepted and ready to land.Aug 3 2019, 11:21 AM
Closed by commit rEFL7869778d02d8: efl_ui_spin: move the step implementation to spin_button (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 3 2019, 11:40 AM
This revision was automatically updated to reflect the committed changes.