efl_ui_spin: move the step implementation to spin_button
ClosedPublic
Actions

Authored by bu5hm4n on Aug 1 2019, 5:00 AM.

Details

Reviewers

segfaultxavi
cedric
zmike

Maniphest Tasks

T7897: efl.ui.spin

Commits

rEFL7869778d02d8: efl_ui_spin: move the step implementation to spin_button

Summary

having efl_ui_spin implementing efl.ui.range_interactive does not make
sense. Efl.Ui.Spin is a not interactive widget, so it should not
implement that interface.

ref T7897

Depends on D9474

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Aug 1 2019, 5:00 AM

Herald added a project: efl. · View Herald TranscriptAug 1 2019, 5:00 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.Aug 1 2019, 5:00 AM

Harbormaster completed remote builds in B12528: Diff 23834.Aug 1 2019, 5:01 AM

Maketh sense, buildeth and paseth tests.

This revision is now accepted and ready to land.Aug 1 2019, 7:15 AM

Actually, this break the Efl.Ui.Spin elm_test, because it is calling efl_ui_range_step_get and _set on the spin in multiple places.

This revision now requires changes to proceed.Aug 1 2019, 7:21 AM

Why was there ever a API call to it ... it was never used ...

fix api calls

bu5hm4n added a child revision: D9488: efl_ui_spin/button: move from elm_ to efl_ prefixed functions.Aug 3 2019, 2:17 AM

Harbormaster completed remote builds in B12549: Diff 23871.Aug 3 2019, 2:17 AM

Nice!

This revision is now accepted and ready to land.Aug 3 2019, 11:21 AM

Closed by commit rEFL7869778d02d8: efl_ui_spin: move the step implementation to spin_button (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 3 2019, 11:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bin/elementary/test_ui_spin.c (7 lines)
M			src/lib/elementary/efl_ui_spin.c (19 lines)
M			src/lib/elementary/efl_ui_spin.eo (5 lines)
M			src/lib/elementary/efl_ui_spin_button.c (25 lines)
M			src/lib/elementary/efl_ui_spin_button.eo (4 lines)
M			src/lib/elementary/efl_ui_spin_button_private.h (2 lines)
M			src/lib/elementary/efl_ui_spin_private.h (1 line)
M			src/tests/elementary/spec/efl_test_range_interactive.c (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23834	2325804		Aug 1 2019, 5:00 AM	★	★
Diff 2	23871	f4e825f	fix api calls	Aug 3 2019, 2:17 AM	★	★
Diff 3	23876	42bbe0e	rEFL7869778d02d862a0efd11857c3299cd391245551	Aug 3 2019, 11:40 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D9488 efl_ui_spin/button: move from elm_ to efl_ prefixed functions
Closed	bu5hm4n	D9475 efl_ui_spin: move the step implementation to spin_button
Closed	bu5hm4n	D9474 efl_ui_spin_button: fix initial displaying of formatting string
Closed	bu5hm4n	D9473 efl_ui_spin_button: stop calling only the parent
Closed	bu5hm4n	D9471 spinner_example: migrate it to efl::ui::spin_button
Closed	bu5hm4n	D9461 efl_ui_spin_button: rename circulate to wraparound
Closed	bu5hm4n	D9460 efl_ui_spec: add a test suite for the steady event
Closed	bu5hm4n	D9459 efl_ui_spin_button: use the newly emitted event from range_interactive
Closed	bu5hm4n	D9458 efl_ui_range_interactive: add a new event