Page MenuHomePhabricator

get rid of shadow variables
ClosedPublic

Authored by billiob on Aug 7 2019, 1:04 PM.

Details

Summary

gl: add some EINA_FALLTHROUGH

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
billiob created this revision.Aug 7 2019, 1:04 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

billiob requested review of this revision.Aug 7 2019, 1:04 PM
zmike requested changes to this revision.Aug 8 2019, 6:09 AM
zmike added a subscriber: zmike.

One nit, otherwise seems good. Thanks!

src/lib/eo/eo.c
3635

Can this be changed to ref_ops for clarity? I'd rather not confuse it with a ref as in refcount.

This revision now requires changes to proceed.Aug 8 2019, 6:09 AM
billiob updated this revision to Diff 23974.Aug 8 2019, 2:14 PM

change variable name

zmike accepted this revision.Aug 8 2019, 2:18 PM
This revision is now accepted and ready to land.Aug 8 2019, 2:18 PM
This revision was automatically updated to reflect the committed changes.