Page MenuHomePhabricator

edje: optimize color_class_recursive_find_helper() function
ClosedPublic

Authored by smohanty on Aug 8 2019, 7:45 PM.

Details

Summary

If the color_class is not overridden by the object level the
hash will be empty but still we do the expensive call to _edje_hash_find_helper()
find the color_class in an empty hash. by checking if the hash is empty
and returning early we save lot of unnecessary hash computaion and lookup.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smohanty created this revision.Aug 8 2019, 7:45 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

smohanty requested review of this revision.Aug 8 2019, 7:45 PM
Hermet accepted this revision.Aug 8 2019, 10:02 PM
This revision is now accepted and ready to land.Aug 8 2019, 10:02 PM
Closed by commit rEFL1b94d90d53dd: edje: optimize color_class_recursive_find_helper() function (authored by subhransu mohanty <sub.mohanty@samsung.com>, committed by Hermet). · Explain WhyAug 8 2019, 10:02 PM
This revision was automatically updated to reflect the committed changes.