Page MenuHomePhabricator

evas_object_textblock: add update for missing font_source
Needs RevisionPublic

Authored by bowonryu on Aug 12 2019, 2:42 AM.

Details

Reviewers
cedric
ali.alzyod
Summary

When doing efl_text_font_set on a textblock,
fmt->font.source is not updated in the _layout_format_push function.
This patch updates fmt->font.source.
So, this allows the font_source from efl_text_font_source_set API to affect efl_text_font_set.

Test Plan

elementary_test -to "efl.ui.text font"

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12650
Build 9095: arc lint + arc unit
bowonryu created this revision.Aug 12 2019, 2:42 AM
bowonryu requested review of this revision.Aug 12 2019, 2:42 AM
cedric requested changes to this revision.Aug 12 2019, 9:17 AM

Can we have a test in our tests suite too?

This revision now requires changes to proceed.Aug 12 2019, 9:17 AM

@bowonryu Does the test depends on local environment ? like ("/images/DejaVuSerif.ttf", "/images/NanumGothic.ttf" )

@ali.alzyod
This is a demo that can simple check the change of font (with font source applied)
but the font files(DejaVuSerif.ttf, NanumGothic.ttf) are missing by mistake.

Anyway this demo will be replaced by test suite.

@cedric
I will update test suite soon.