Page MenuHomePhabricator

csharp: MVVM parts support
ClosedPublic

Authored by lauromoura on Aug 13 2019, 7:54 PM.

Details

Summary

Parts binding will follow a similar approach to regular property
binding:

var error = factory.PartName().PropertyName().Bind(modelProperty);

  • Changed both Bind() overloads to return the error code from efl_ui_property_bind
  • Also properties from interfaces implemented didn't have their Bindable wrapper methds available.

Depends on D9563

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Aug 13 2019, 7:54 PM
lauromoura requested review of this revision.Aug 13 2019, 7:54 PM

Added the DO NOT MERGE tag so we can start reviewing this while we fix an issue regarding getting the part from the binder.

Update the test after updates in the C binding process

Patch is good for review and merging.

cedric requested changes to this revision.Aug 19 2019, 9:52 AM

Neat. Just please correct the commit message :

var error = factory.PartName().PartProperty().Bind(modelProperty);

Should be :

var error = factory.PartName().PropertyName().Bind(modelProperty);
This revision now requires changes to proceed.Aug 19 2019, 9:52 AM
lauromoura updated this revision to Diff 24215.Aug 19 2019, 1:31 PM

Update commit message

cedric accepted this revision.Aug 19 2019, 1:37 PM

Update commit message

I don't know if it worked, because phab. So I will let you land this and mark this patch has approved.

This revision is now accepted and ready to land.Aug 19 2019, 1:37 PM

arc patch didn't retrieve a different commit message

lauromoura edited the summary of this revision. (Show Details)Aug 19 2019, 1:42 PM

arc patch didn't retrieve a different commit message

Updated the diff description. Arc patch must take the commit message from there.

This revision was automatically updated to reflect the committed changes.