efl_ui_text_editable: remove Efl.Ui.TextEditable class
AbandonedPublic
Actions

Authored by YOhoho on Aug 14 2019, 4:46 AM.

Details

Reviewers

segfaultxavi
zmike
tasn

Summary

Because interactive_editable is true by default in Efl.Ui.Text,
Efl.Ui.Text and Efl.Ui.TextEditable are exactly same classes.
There is no reason to keep identical classes.

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12684
Build 9113: arc lint + arc unit

YOhoho created this revision.Aug 14 2019, 4:46 AM

Herald added a project: efl. · View Herald TranscriptAug 14 2019, 4:46 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

YOhoho requested review of this revision.Aug 14 2019, 4:46 AM

Harbormaster completed remote builds in B12684: Diff 24072.Aug 14 2019, 4:46 AM

YOhoho added a child revision: D9571: efl_ui_text: rename to efl_ui_text_entry.Aug 14 2019, 4:54 AM

I think it is useful to have two separate classes, because these two behaviors (editable and non-editable) are different enough.
I do not know why the default for Efl.Ui.Text is now editable but instead of removing one class, I would make their behaviors different again:
Either we make Efl.Ui.Text non-editable by default, or we rename Efl.Ui.Text_Editable to something like Efl.Ui.Label.

In D9570#190310, @segfaultxavi wrote:

I think it is useful to have two separate classes, because these two behaviors (editable and non-editable) are different enough.
I do not know why the default for Efl.Ui.Text is now editable but instead of removing one class, I would make their behaviors different again:
Either we make Efl.Ui.Text non-editable by default, or we rename Efl.Ui.Text_Editable to something like Efl.Ui.Label.

That's exactly what we have in the new text work: Efl.Ui.Text is editable, and Efl.Ui.Label is not.

I'm happy to rename if you have any other suggestions.

YOhoho abandoned this revision.Oct 31 2019, 7:34 PM

Revision Contents
Changeset List

		Path
M		src/bin/elementary/test_gfx_filters.c (2 lines)
M		src/examples/elementary/efl_ui_unit_converter.cs (4 lines)
M		src/lib/elementary/Efl_Ui.h (1 line)
M		src/lib/elementary/Elementary.h (1 line)
M		src/lib/elementary/efl_ui_text.c (19 lines)
D	M	src/lib/elementary/efl_ui_text_editable.eo (8 lines)
M		src/lib/elementary/meson.build (1 line)