Page MenuHomePhabricator

efl_ui_text_editable: remove Efl.Ui.TextEditable class
AbandonedPublic

Authored by YOhoho on Aug 14 2019, 4:46 AM.

Details

Summary

Because interactive_editable is true by default in Efl.Ui.Text,
Efl.Ui.Text and Efl.Ui.TextEditable are exactly same classes.
There is no reason to keep identical classes.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12684
Build 9113: arc lint + arc unit
YOhoho created this revision.Aug 14 2019, 4:46 AM
YOhoho requested review of this revision.Aug 14 2019, 4:46 AM

I think it is useful to have two separate classes, because these two behaviors (editable and non-editable) are different enough.
I do not know why the default for Efl.Ui.Text is now editable but instead of removing one class, I would make their behaviors different again:
Either we make Efl.Ui.Text non-editable by default, or we rename Efl.Ui.Text_Editable to something like Efl.Ui.Label.

tasn added a comment.Oct 1 2019, 1:27 AM

I think it is useful to have two separate classes, because these two behaviors (editable and non-editable) are different enough.
I do not know why the default for Efl.Ui.Text is now editable but instead of removing one class, I would make their behaviors different again:
Either we make Efl.Ui.Text non-editable by default, or we rename Efl.Ui.Text_Editable to something like Efl.Ui.Label.

That's exactly what we have in the new text work: Efl.Ui.Text is editable, and Efl.Ui.Label is not.

I'm happy to rename if you have any other suggestions.

YOhoho abandoned this revision.Thu, Oct 31, 7:34 PM