Page MenuHomePhabricator

eolian-mono: Add support for multi-value properties with tuples
ClosedPublic

Authored by lauromoura on Aug 15 2019, 5:04 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
felipealmeida created this revision.Aug 15 2019, 5:04 PM
felipealmeida requested review of this revision.Aug 15 2019, 5:04 PM
lauromoura added inline comments.Aug 15 2019, 7:14 PM
src/lib/eolian_cxx/grammar/counter.hpp
3

Extra _HH

17

Remove these commented out lines?

src/tests/efl_mono/Eo.cs
356

There shouldn't be an Assert here comparing the retrieved value?

lauromoura commandeered this revision.Mon, Aug 19, 4:03 PM
lauromoura edited reviewers, added: felipealmeida; removed: lauromoura.
lauromoura updated this revision to Diff 24225.Mon, Aug 19, 4:04 PM

Update with header cleanup and testing properties

Oh, also updated after small conflict with @static in the test eo.

I'd really like @segfaultxavi opinion about the idea.

I didn't know tuples existed in C# so I cannot comment much.
However, anything to make usage of EFL under C# more natural sounds like a good idea to me. Multivalued eo properties did not generate C# properties before, so I see no harm in this patch.

Just one thing, can you test how do the generated DocFX pages look like when tuples are involved?

Just one thing, can you test how do the generated DocFX pages look like when tuples are involved?

I've added some screenshots from Efl.Ui.Spin properties to https://imgur.com/a/AnUnyTi

Cool, everything looks fine on the docfx side. Thanks for the screenshots, I'm away from my work computer :)

felipealmeida accepted this revision.Fri, Aug 23, 10:07 AM
This revision is now accepted and ready to land.Fri, Aug 23, 10:07 AM
This revision was automatically updated to reflect the committed changes.