efl_ui_default_item: remove item parts
ClosedPublic
Actions

Authored by bu5hm4n on Aug 16 2019, 8:54 AM.

Details

Reviewers

cedric
zmike

Maniphest Tasks

T8115: Provide group feature to PositionManager

Commits

rEFL2dfc69397bb1: efl_ui_default_item: remove item parts

Summary

these parts are hard copies of the part implementations given from the
layouts. Replacing them with the layout implementation just works

ref T8115

Diff Detail

Repository

rEFL core/efl

Branch

devs/bu5hm4n/items_work

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 12703

bu5hm4n created this revision.Aug 16 2019, 8:54 AM

Herald added a project: efl. · View Herald TranscriptAug 16 2019, 8:54 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.Aug 16 2019, 8:54 AM

bu5hm4n added a child revision: D9583: introduce group item.

Harbormaster completed remote builds in B12703: Diff 24108.Aug 16 2019, 8:55 AM

Hero!

This revision is now accepted and ready to land.Aug 16 2019, 10:14 AM

Just for my personal understanding, what is going on here?
I see that 3 item parts are being mapped onto 2 layout parts. Isn't there an overlap?

Efl.Ui.Item_Part_Icon and Efl.Ui.Item_Part_Extra and Efl.Ui.Item_Part_Content are plain copies of each other.

Ah, ok, copies of each other. I thought they had copies in Layout. Thx!

zmike accepted this revision.Aug 19 2019, 5:35 AM

Needs rebase

This revision now requires changes to proceed.Aug 19 2019, 5:39 AM

rebase

Harbormaster completed remote builds in B12785: Diff 24203.Aug 19 2019, 9:23 AM

I might have forgotten the child revision of this :( sorry.

cedric requested changes to this revision.Aug 20 2019, 12:03 PM

cedric added inline comments.

src/lib/elementary/efl_ui_default_item.eo
20	Sorry I missed this, the part is extra in your efl_part_get implementation.

This revision now requires changes to proceed.Aug 20 2019, 12:03 PM

I just forgot this in the revision, its updated.

This revision was not accepted when it landed; it landed in state Needs Revision.Aug 20 2019, 10:51 PM

Closed by commit rEFL2dfc69397bb1: efl_ui_default_item: remove item parts (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
~		src/lib/elementary/Elementary.h (4 lines)
~		src/lib/elementary/efl_ui_default_item.c (6 lines)
~		src/lib/elementary/efl_ui_default_item.eo (6 lines)
~		src/lib/elementary/efl_ui_item.c (126 lines)
D	M	src/lib/elementary/efl_ui_item_part_content.eo (9 lines)
D	M	src/lib/elementary/efl_ui_item_part_extra.eo (9 lines)
D	M	src/lib/elementary/efl_ui_item_part_icon.eo (9 lines)
D	M	src/lib/elementary/efl_ui_item_part_text.eo (11 lines)
~		src/lib/elementary/efl_ui_list_placeholder_item.c (2 lines)
~		src/lib/elementary/efl_ui_list_placeholder_item.eo (2 lines)
~		src/lib/elementary/meson.build (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24108	ed60162		Aug 16 2019, 8:54 AM	★	★
Diff 2	24203	2041b41	rebase	Aug 19 2019, 9:23 AM	★	★
Diff 3	24288	1856596	rEFL2dfc69397bb159cbd55c82ac5f8683be8726c267	Aug 20 2019, 10:50 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
79a9f39a4693	98231722505c	ed60162702ec	Marcel Hollerbach	(Show More…)	Aug 16 2019, 12:32 AM

Status	Author	Revision
Closed	bu5hm4n	D9630 efl_ui_position_manager_common: generalize code
Closed	bu5hm4n	D9609 replace item_container benchmark
Closed	bu5hm4n	D9608 efl_ui_position_manager_grid: start to honor group items
Closed	bu5hm4n	D9607 efl_ui_position_manager_common: fix buffer_id
Closed	bu5hm4n	D9587 efl_ui_position_manager_list: make it handle group items
Closed	bu5hm4n	D9586 efl_ui_position_manager: pass on information about group ids
Closed	bu5hm4n	D9585 elm_test: add group items
Closed	bu5hm4n	D9584 elm_test: rename file and remove wrong names
Closed	bu5hm4n	D9583 introduce group item
Closed	bu5hm4n	D9582 efl_ui_default_item: remove item parts
Closed	bu5hm4n	D9629 introduce default item