Page MenuHomePhabricator

efl_ui_widget: optimize size / position setting
ClosedPublic

Authored by bu5hm4n on Aug 19 2019, 2:52 AM.

Details

Summary

calling geometry set here is again calling the API in canvas object that
splits this call to size_set and position_set which means we spent quite
a bit of time in eo, just to call the same APIs we could call directly.
With this commit here, the calls are directly going to the right
objects, with the right API.

Depends on D9618

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Aug 19 2019, 2:52 AM
bu5hm4n requested review of this revision.Aug 19 2019, 2:52 AM
zmike requested changes to this revision.Aug 19 2019, 6:29 AM
zmike added inline comments.
src/lib/elementary/efl_ui_widget.c
812–820

Shouldn't this be removed?

845

This probably needs a call to _elm_widget_shadow_update

This revision now requires changes to proceed.Aug 19 2019, 6:29 AM
bu5hm4n updated this revision to Diff 24201.Aug 19 2019, 8:51 AM
bu5hm4n edited the summary of this revision. (Show Details)

remove stupid API calls - what is wrong with me?

zmike accepted this revision.Aug 19 2019, 9:05 AM
This revision is now accepted and ready to land.Aug 19 2019, 9:05 AM
cedric accepted this revision.Aug 19 2019, 9:50 AM
Closed by commit rEFLead8a280570b: efl_ui_widget: optimize size / position setting (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 19 2019, 10:43 PM
This revision was automatically updated to reflect the committed changes.