Page MenuHomePhabricator

introduce default item
ClosedPublic

Authored by bu5hm4n on Aug 19 2019, 9:24 AM.

Details

Summary

default item is used as base class for all "normal style" efl items.

A "normal style" efl item does have a text,content & extra part.

  • The text part is usally used to express some text in the item
  • Content part is the *main* content part where the user attention is

on.

  • Extra can be used to display some elements that are not directly

getting the attention of the user, it can be seen as something more than
the decoration item field.

ref T8115

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Aug 19 2019, 9:24 AM
bu5hm4n requested review of this revision.Aug 19 2019, 9:24 AM
cedric requested changes to this revision.Aug 19 2019, 9:48 AM
cedric added inline comments.
src/lib/elementary/efl_ui_default_item.eo
21

Is it extra or end?

src/lib/elementary/efl_ui_list_default_item.c
26

Didn't you talk about having an automatic detection of the position manager type and select the klass that way? This was to remove the need to have grid/list custom item.

This revision now requires changes to proceed.Aug 19 2019, 9:48 AM
bu5hm4n requested review of this revision.Aug 19 2019, 9:52 AM
bu5hm4n added inline comments.
src/lib/elementary/efl_ui_default_item.eo
21

i do not know if we now call it extra or end, end is how it was called before, so i go with end, if we want to rename it to extra, lets do it in one go, but i do not want to mix too many things at once.

src/lib/elementary/efl_ui_list_default_item.c
26

That can come at some later point. Getting one layout to support both is quite hard, and i gave up on this, i think this is a start, and we still can improve.

cedric added inline comments.Aug 19 2019, 10:03 AM
src/lib/elementary/efl_ui_default_item.eo
21

It is just that in this patch you implement it as "extra" in src/lib/elementary/efl_ui_default_item.c . So I would expect it to be extra here to or use "end" in the .c file.

src/lib/elementary/efl_ui_list_default_item.c
26

Ok. Just fix the end/extra issue and I am fine with this patch.

bu5hm4n added inline comments.Aug 19 2019, 10:10 AM
src/lib/elementary/efl_ui_default_item.eo
21

Oh - its end in efl_ui_list_default_item.c but extra in efl_ui_grid_default_item.c *GREAT*

bu5hm4n updated this revision to Diff 24248.Aug 19 2019, 10:45 PM

end -> extra

it seems grid called it end before, list called it extra, its now called extra

This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2019, 10:51 PM
Closed by commit rEFL185659669837: introduce default item (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.