Page MenuHomePhabricator

efl_ui_panel: remove dependency with elm_interface_scrollable
ClosedPublic

Authored by YOhoho on Aug 19 2019, 9:35 PM.

Details

Summary

elm_interface_scrollable is replaced with efl_ui_scrollable_interative.

Legacy code related to SCROLL event is removed because eo SCROLL event have
void event info.

in lib/efl/inferfaces/efl_ui_scrollable.eo

scroll: void; [[Called when scrolling]]

I think we need to add new PANEL_SCROLL event that have Efl_Ui_Panel_Scroll_Info

Test Plan

elementary_test -to 'Efl.Ui.Panel Scrollable'

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
YOhoho created this revision.Aug 19 2019, 9:35 PM
YOhoho requested review of this revision.Aug 19 2019, 9:35 PM
YOhoho updated this revision to Diff 24241.Aug 19 2019, 9:43 PM
YOhoho edited the summary of this revision. (Show Details)

Update summary

ERR<20003>:eo ../src/lib/eo/eo.c:578 _efl_object_call_resolve() in src/lib/efl/interfaces/efl_ui_scrollable_interactive.eo.c:23: func 'efl_ui_scrollable_scroll_freeze_set' (3088) could not be resolved for class 'Elm.List'.
## Copy & Paste the below (until EOF) into a terminal, then hit Enter

I get this error when i am starting "Efl.Ui.Panel Scrollable" in elm_test.

ERR<20003>:eo ../src/lib/eo/eo.c:578 _efl_object_call_resolve() in src/lib/efl/interfaces/efl_ui_scrollable_interactive.eo.c:23: func 'efl_ui_scrollable_scroll_freeze_set' (3088) could not be resolved for class 'Elm.List'.
## Copy & Paste the below (until EOF) into a terminal, then hit Enter

I get this error when i am starting "Efl.Ui.Panel Scrollable" in elm_test.

D9669 will fix that error.

bu5hm4n accepted this revision.Aug 21 2019, 2:45 AM
This revision is now accepted and ready to land.Aug 21 2019, 2:45 AM
Closed by commit rEFL1c1382e09bb4: efl_ui_panel: remove dependency with elm_interface_scrollable (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 21 2019, 2:59 AM
This revision was automatically updated to reflect the committed changes.