Page MenuHomePhabricator
Differential D9661

suite_helpers: punsh some sanity into function names
ClosedPublic
Actions

Authored by bu5hm4n on Aug 20 2019, 11:12 PM.

Details

Reviewers
Jaehyun_Cho
SanghyeonLee
zmike
segfaultxavi
Commits
rEFL1c1c3685fee0: suite_helpers: punsh some sanity into function names
Summary

Depends on D9660

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Aug 20 2019, 11:12 PM
zmike added a reviewer: segfaultxavi.Aug 21 2019, 10:49 AM

This looks like it's removing docs, summoning doc cop...

segfaultxavi added a comment.Aug 22 2019, 9:18 AM

*sigh* fricking workaholic OCD...

Yeah, you could at least keep the old function name as a comment. It was a surreal function name but it conveyed more information.

zmike accepted this revision.Aug 26 2019, 4:58 AM
This revision is now accepted and ready to land.Aug 26 2019, 4:58 AM
Closed by commit rEFL1c1c3685fee0: suite_helpers: punsh some sanity into function names (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 26 2019, 5:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24502

View Options

src/tests/elementary/efl_ui_test_popup.c

Loading...
View Options

src/tests/elementary/elm_test_actionslider.c

Loading...
View Options

src/tests/elementary/elm_test_bubble.c

Loading...
View Options

src/tests/elementary/suite_helpers.h

Loading...
View Options

src/tests/elementary/suite_helpers.c

Loading...