Page MenuHomePhabricator

efl_ui/scrollable_content: add scrollable_text property
ClosedPublic

Authored by zmike on Aug 21 2019, 7:43 AM.

Details

Summary

this creates a label with a scroller and manages sizing calcs

note that efl_ui_text cannot be used here because its sizing calc model
is incompatible with efl

Depends on D9675

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Aug 21 2019, 7:43 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Aug 21 2019, 7:43 AM
bu5hm4n added inline comments.
src/lib/elementary/efl_ui_widget_scrollable_content.c
218

what happens if there is already content ?

zmike added inline comments.Aug 21 2019, 12:13 PM
src/lib/elementary/efl_ui_widget_scrollable_content.c
218

It gets automatically deleted.

bu5hm4n accepted this revision.Aug 21 2019, 12:24 PM

cool.

This revision is now accepted and ready to land.Aug 21 2019, 12:24 PM
zmike updated this revision to Diff 24407.Aug 22 2019, 3:58 PM
zmike edited the summary of this revision. (Show Details)

rebase

Closed by commit rEFL1d2d15bbf844: efl_ui/scrollable_content: add scrollable_text property (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 22 2019, 10:35 PM
This revision was automatically updated to reflect the committed changes.

So at any given time only scrollable_content or scrollable_text can be set, right?
Setting one removes the other.

And you thought this was not worth explaining in the docs??? Fix.

Also, what happens if I call content_set and then try text_get? This should be in the docs too.