Page MenuHomePhabricator

elm/config: avoid unnecessary elm cache flush
ClosedPublic

Authored by smohanty on Aug 21 2019, 11:34 PM.

Details

Summary

in config_apply() we load the deafult theme and then
elm_recache() just throws it away.

so just move it before config_apply for time being.
We need to revisit to check if we really need that elm_recache() in that
function or not.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smohanty created this revision.Aug 21 2019, 11:34 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

smohanty requested review of this revision.Aug 21 2019, 11:34 PM

Looks like this is a copy paste error by looking at the position of _elm_recache() function in all 3 places.

Before this patch the default theme file was loading twice as _elm_recache() will unload the file and clear the cache.

If somebody knows the code .. please put another patch to a new internal function and name/comment it properly why we need those stuff does this elm_recache() needed. (maybe rename to elm_cache_clear() for better code readability.

Or if someone explain what exactly going on i can raise separate patch for that.

zmike accepted this revision.Aug 22 2019, 5:13 AM
zmike added a subscriber: zmike.

There's no notes in the patch which added this, so I think we can just assume that it was a mistake.

This revision is now accepted and ready to land.Aug 22 2019, 5:13 AM
Closed by commit rEFL10b2f65e6065: elm/config: avoid unnecessary elm cache flush (authored by subhransu mohanty <sub.mohanty@samsung.com>, committed by zmike). · Explain WhyAug 22 2019, 5:14 AM
This revision was automatically updated to reflect the committed changes.