Page MenuHomePhabricator
Differential D9722

efl_ui_item: only fetch multiselection state if this is relevant
ClosedPublic
Actions

Authored by bu5hm4n on Aug 23 2019, 3:28 AM.

Details

Reviewers
raster
zmike
cedric
tasn
Commits
rEFLc947485bd094: efl_ui_item: only fetch multiselection state if this is relevant
Summary

there are cases where the container does only implement single
selection, when then just asume implicitly single mode here.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Aug 23 2019, 3:28 AM
bu5hm4n requested review of this revision.Aug 23 2019, 3:28 AM
bu5hm4n added a child revision: D9723: efl_ui_item: add keybindings for selecting changes.
zmike accepted this revision.Aug 23 2019, 11:17 AM
This revision is now accepted and ready to land.Aug 23 2019, 11:17 AM
segfaultxavi added a subscriber: segfaultxavi.Aug 24 2019, 1:51 AM

For the future, I'd like the commit message to say what is this fixing. There was a crash before this patch, for example?
Also the error message is very uninformative.

bu5hm4n added a comment.Aug 25 2019, 11:58 PM

It is not fixing anything in particular. Before the item class has never been used in connection sith Single_Selectable. In the next commit this will be introduced. Its not really a fix, it just ... makes it work.

Closed by commit rEFLc947485bd094: efl_ui_item: only fetch multiselection state if this is relevant (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 26 2019, 5:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/elementary/efl_ui_item.c (15 lines)

Diff 24499

View Options

src/lib/elementary/efl_ui_item.c

Loading...